[webkit-reviews] review granted: [Bug 31067] Chromium crashes when a plugin invokes the document.open function via NPAPI : [Attachment 42669] Updated patch with the document.open invocation from the plugin now done in npp_destroystream

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Ananta Iyengar
<ananta at chromium.org>'s request for review:
Bug 31067: Chromium crashes when a plugin invokes the document.open function
via NPAPI
https://bugs.webkit.org/show_bug.cgi?id=31067

Attachment 42669: Updated patch with the document.open invocation from the
plugin now done in npp_destroystream
https://bugs.webkit.org/attachment.cgi?id=42669&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This looks great.  One typo:

 132	 if (frame)
 133	     htmlDocument->writeln(writeHelperGetString(args), frame ?
frame->document() : NULL);

We don't want the "if (frame)" here.  I can either fix this you on landing or
we can use commit-queue if you upload a new patch.