[webkit-reviews] review denied: [Bug 31195] File upload control shows a single filename even if multiple files are selected : [Attachment 42623] Proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied TAMURA, Kent <tkent at chromium.org>'s
request for review:
Bug 31195: File upload control shows a single filename even if multiple files
are selected
https://bugs.webkit.org/show_bug.cgi?id=31195

Attachment 42623: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=42623&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	     RenderButton {INPUT} at (0,0) size 78x18 [bgcolor=#C0C0C0]
> +	       RenderBlock (anonymous) at (8,2) size 62x13
> +		 RenderText at (0,0) size 62x13
> +		   text run at (0,0) width 62: "Choose File"
> +	   RenderText {#text} at (0,0) size 0x0
> +	 RenderBlock {P} at (0,38) size 784x18
> +	   RenderText {#text} at (0,0) size 442x18
> +	     text run at (0,0) width 442: "The file upload control above should
have text '2 files,' not a filename."

This render tree output looks like a failure. The test says the text should be
"2 files", but the text says "Choose File". What's up?

review- because of the test failure issue -- the patch otherwise looks fine