[webkit-reviews] review denied: [Bug 5863] feMorphology filter is not implemented : [Attachment 42647] feMorphology filter

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has denied Dirk Schulze
<krit at webkit.org>'s request for review:
Bug 5863: feMorphology filter is not implemented
https://bugs.webkit.org/show_bug.cgi?id=5863

Attachment 42647: feMorphology filter
https://bugs.webkit.org/attachment.cgi?id=42647&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Nice job Dirk,

some style nitpicks:

> +    if (m_radiusX == 0 || m_radiusY == 0)
> +	   return;

if (!m_radiusX || !m_radiusY)


> +    radiusX = std::min(effectDrawingRect.width() - 1, radiusX);

I suggest to use "using std::min" / "using std::max" in the beginning.

> +		       if ((m_type == 1 && pixel <= columnExtrema) || (m_type
== 2 && pixel >= columnExtrema))
...

> +		       if ((m_type == 1 && extrema[kernelIndex] <=
entireExtrema) ||
> +			   (m_type == 2 && extrema[kernelIndex] >=
entireExtrema))
...

Don't we have any named constants for this? Didn't check the source...
Please clarify these things, almost ready to give r+.