[webkit-reviews] review denied: [Bug 31050] [Multipatch] JSVALUE32_64 support on ARM : [Attachment 42566] Second patch

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has denied Zoltan Herczeg
<zherczeg at inf.u-szeged.hu>'s request for review:
Bug 31050: [Multipatch] JSVALUE32_64 support on ARM
https://bugs.webkit.org/show_bug.cgi?id=31050

Attachment 42566: Second patch
https://bugs.webkit.org/attachment.cgi?id=42566&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
As discussed in irc, I've landed a version of the OBJECT_OFFSETOF(struct
JITStackFrame, args) change in r50594.
Also, I've changed the shift behaviour in r50595, so the extra and32's on the
shifts should no longer be required.

Also as discussed in irc, some ASSERTs to guard THUNK_RETURN_ADDRESS_OFFSET
would be a great improvement.

The empty '#elif PLATFORM(ARM_TRADITIONAL)' in JIT.h was a little confusing,
would be great to add a quick comment explaining why this section is empty
(something like "// patchOffset... values should go here; JIT optimizations
currently not supported on ARM with JSVALUE32_64.").

Otherwise looks good to go, r- since you'll need to update to r50594, r50595,
but should be a straight r+ after that.