[webkit-reviews] review granted: [Bug 31177] Web Inspector: Bind backspace to delete cookies and DOM Storage : [Attachment 42624] Fix w/ Refactoring

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 5 21:09:37 PST 2009


Timothy Hatcher <timothy at hatcher.name> has granted Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 31177: Web Inspector: Bind backspace to delete cookies and DOM Storage
https://bugs.webkit.org/show_bug.cgi?id=31177

Attachment 42624: Fix w/ Refactoring
https://bugs.webkit.org/attachment.cgi?id=42624&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>

> -    this.dataGrid = new WebInspector.DataGrid(columns);
> +    this.dataGrid = new WebInspector.DataGrid(columns, null, null);

You don't really need to pass nul, null here, they will be undefined if left
off and that works for your if (editCallback) and if (deleteCallback) checks.

We can get rid of DOMStorageDataGrid.js and make DOMStorageItemsView handle the
callbacks.


More information about the webkit-reviews mailing list