[webkit-reviews] review requested: [Bug 18831] [GTK] support windowless plugins : [Attachment 42620] gtk windowless v4

[bugzilla-daemon at webkit.org]

Brian Tarricone <bjt23 at cornell.edu> has asked  for review:
Bug 18831: [GTK] support windowless plugins
https://bugs.webkit.org/show_bug.cgi?id=18831

Attachment 42620: gtk windowless v4
https://bugs.webkit.org/attachment.cgi?id=42620&action=review

------- Additional Comments from Brian Tarricone <bjt23 at cornell.edu>
Changes from last patch:

* If needed, set the GdkColormap on the plugin's GdkPixmap wrapper (necessary
if the plugin does not use gtk).
* Don't bail on visual/colormap selection if xrender>=0.5 isn't found unless
depth is also 32.
* Add ChangeLog entry.

I'm feeling decently good about this.  It's not perfect, but it seems to work
at least as well as the windowless support for Qt.  I'd like to get at least
this much checked in if possible and then handle fixes/improvements as they
become necessary.

There's also some work that can be done to avoid some code duplication between
the Qt and gtk backends for this, which is probably best done in a future
patch.