[webkit-reviews] review granted: [Bug 31189] Web Inspector: brush up inspector tests : [Attachment 42600] [PATCH]

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 31189: Web Inspector: brush up inspector tests
https://bugs.webkit.org/show_bug.cgi?id=31189

Attachment 42600: [PATCH]
https://bugs.webkit.org/attachment.cgi?id=42600&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>

> +	   for (var i = 0; i < result.length; ++i) {
> +	       output(result[i].text + " " + result[i].clazz);
> +	   }

No braces.


> -	   var output = document.getElementById("output");
> +	   var output = document.getElementById("outputPre");

I don't think Pre helps. What was wrong with output?


> +window.didEvaluateForTestInFrontend = function(callId, jsonResult)

This should just be function didEvaluateForTestInFrontend(callId, jsonResult)


> +//Fronten functions.

Typo. Needs space after //.


> +// Fronten functions.

Typo.