[webkit-reviews] review requested: [Bug 31187] Get rid of phase argument to Image::drawPattern : [Attachment 42597] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 5 14:25:25 PST 2009


Benjamin Otte <otte at gnome.org> has asked  for review:
Bug 31187: Get rid of phase argument to Image::drawPattern
https://bugs.webkit.org/show_bug.cgi?id=31187

Attachment 42597: patch
https://bugs.webkit.org/attachment.cgi?id=42597&action=review

------- Additional Comments from Benjamin Otte <otte at gnome.org>
The attach patch removes the phase argument from Image::dawPattern(). The
argument can be expressed equally well as part of the patternTransform. 
In fact, all backends but the Qt one did exactly that manually anyway.

I only compiled and tested this patch on Linux/gtk. I did the work on all other
backends too (it was just deleting code after all), but I won't wouch for it.


More information about the webkit-reviews mailing list