[webkit-reviews] review requested: [Bug 31122] [Qt] editing/selection/shrink-selection-after-shift-pagedown.html failing : [Attachment 42582] fix test case

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 5 11:43:56 PST 2009


Chang Shu <Chang.Shu at nokia.com> has asked  for review:
Bug 31122: [Qt] editing/selection/shrink-selection-after-shift-pagedown.html
failing
https://bugs.webkit.org/show_bug.cgi?id=31122

Attachment 42582: fix test case
https://bugs.webkit.org/attachment.cgi?id=42582&action=review

------- Additional Comments from Chang Shu <Chang.Shu at nokia.com>
The original writer of the test case, Enrica Casucci [enrica at apple.com],
pointed out that shift-PageDown is required for the test case. So my previous
proposal of replacing it using multiple shift-arrowdown is not an option. Then
I came up with this patch.
This patch fixes the test case so that it no longer depends on the exact number
of lines selected. On Qt, shift-pagedown has been implemented for bug 31166 and
landed. I tested both Qt and Mac and this patch worked. I also think it should
fix bug 31103, a GTK regression on this test case.


More information about the webkit-reviews mailing list