[webkit-reviews] review granted: [Bug 31152] Fix ASSERT(currentStyle = renderStyle()) : [Attachment 42545] Fix ASSERT(currentStyle = renderStyle()).

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 5 10:20:26 PST 2009


Alexey Proskuryakov <ap at webkit.org> has granted Yuta Kitamura
<yutak at chromium.org>'s request for review:
Bug 31152: Fix ASSERT(currentStyle = renderStyle())
https://bugs.webkit.org/show_bug.cgi?id=31152

Attachment 42545: Fix ASSERT(currentStyle = renderStyle()).
https://bugs.webkit.org/attachment.cgi?id=42545&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
Wow. r=me

The ChangeLog is not in great shape - why repeat the same line twice, for
example? Also, the line saying 'We should have used "==" instead of "=". should
go after the automatically inserted function name (pseudoStyleCacheIsInvalid),
because it describes what was changed in that particular function.


More information about the webkit-reviews mailing list