[webkit-reviews] review granted: [Bug 31122] [Qt] editing/selection/shrink-selection-after-shift-pagedown.html failing : [Attachment 42502] this patch implements the support for shift-pageup and shift-pagedown.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 5 06:44:41 PST 2009


Tor Arne Vestbø <vestbo at webkit.org> has granted  review:
Bug 31122: [Qt] editing/selection/shrink-selection-after-shift-pagedown.html
failing
https://bugs.webkit.org/show_bug.cgi?id=31122

Attachment 42502: this patch implements the support for shift-pageup and
shift-pagedown.
https://bugs.webkit.org/attachment.cgi?id=42502&action=review

------- Additional Comments from Tor Arne Vestbø <vestbo at webkit.org>
LGTM, but please wrap the else before submitting, ie:

if (kevent->shiftKey())
    frame->editor()->command("MovePageDownAndModifySelection").execute();
else
    frame->editor()->command("MovePageDown").execute();


More information about the webkit-reviews mailing list