[webkit-reviews] review denied: [Bug 31145] Need notification of scrolling frame : [Attachment 42532] Adds FrameLoaderClient::didChangeScrollOffset
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 4 23:22:54 PST 2009
Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Scott Violet
<sky at google.com>'s request for review:
Bug 31145: Need notification of scrolling frame
https://bugs.webkit.org/show_bug.cgi?id=31145
Attachment 42532: Adds FrameLoaderClient::didChangeScrollOffset
https://bugs.webkit.org/attachment.cgi?id=42532&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebCore/ChangeLog
..
> + Reviewed by NOBODY (OOPS!).
> +
> + Adds FrameLoaderClient::didChangeScrollOffset that is called when
> + the frame scrolls. This will be used to know when history state
> + needs to be updated.
^^^ fix the indentation
please include a link to this bug. delete the line below:
> + No new tests.
LGTM otherwise
More information about the webkit-reviews
mailing list