[webkit-reviews] review requested: [Bug 25415] [GTK][ATK] Please implement support for get_text_at_offset : [Attachment 42544] Fix for the issue in comment 59

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 4 21:17:31 PST 2009


Joanmarie Diggs <joanmarie.diggs at gmail.com> has asked  for review:
Bug 25415: [GTK][ATK] Please implement support for get_text_at_offset
https://bugs.webkit.org/show_bug.cgi?id=25415

Attachment 42544: Fix for the issue in comment 59
https://bugs.webkit.org/attachment.cgi?id=42544&action=review

------- Additional Comments from Joanmarie Diggs <joanmarie.diggs at gmail.com>
This seems to fix the issue I pointed out in comment 59, namely:

> At the bottom of http://live.gnome.org/Orca is a line stating who did the
last
> edit.
> 
>   acc.name
>   'Orca (last edited 2009-07-14 15:13:57 by '
> 
> (Note that my window is sized so that the whole thing is on a single line.)
> 
>   acc.queryText().getTextAtOffset(0, TEXT_BOUNDARY_LINE_START)
>   ('Orca (', 0, 6)

Assuming this solution (or one I generate post-review) is acceptable, I believe
that only leaves the invalid pointer issue from comment #55.


More information about the webkit-reviews mailing list