[webkit-reviews] review requested: [Bug 31116] WebInspector: Corrects InspectorBackent::platform() on Windows. : [Attachment 42516] Alternate solution patch: webkit port identifier

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 4 13:23:35 PST 2009


Jocelyn Turcotte <jocelyn.turcotte at nokia.com> has asked  for review:
Bug 31116: WebInspector: Corrects InspectorBackent::platform() on Windows.
https://bugs.webkit.org/show_bug.cgi?id=31116

Attachment 42516: Alternate solution patch: webkit port identifier
https://bugs.webkit.org/attachment.cgi?id=42516&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at nokia.com>
If we want to keep a WIN_OS wide platform identifier, I would rather use this
solution instead.

Unlike the PLATFORM macro on the C++ side, InspectorController.platform()
returns a single value that must identify both the webkit flavor and the OS.

Tell me if you prefer this solution or the first one, which should use
identifers like qt-windows, qt-mac, gtk-linux if needed to switch different
behavior/appearance of the inspector on different OS.


More information about the webkit-reviews mailing list