[webkit-reviews] review denied: [Bug 31137] Adds a cursory check of the ChangeLog in svn-create-patch : [Attachment 42508] Adds some style checks of the ChangeLog file in svn-create-patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 4 12:54:08 PST 2009


Timothy Hatcher <timothy at hatcher.name> has denied Eric Ayers
<zundel at google.com>'s request for review:
Bug 31137: Adds a cursory check of the ChangeLog in svn-create-patch
https://bugs.webkit.org/show_bug.cgi?id=31137

Attachment 42508: Adds some style checks of the ChangeLog file in
svn-create-patch
https://bugs.webkit.org/attachment.cgi?id=42508&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>

> +    if ($patch =~ /^\+\t/m) {
> +	   push(@styleMessages, " - ChangeLog contains leading tab
character.");

No tabs are allowed, leading or otherwise.


> +    if (!($patch =~ /^\+.*https:\/\/bugs.webkit.org\//m)) {
> +	   push(@styleMessages, " - No bug URL found in ChangeLog entry.");

Another valid format is http://webkit.org/b/XXXXX. If we care.


> +	       warn("* Problems found in ".$file.":\n" . join("\n",
@styleMessages) . "\n");

Put spaces around the "."s or put $file directly in the string.

r- for the tab check being restrictive.


More information about the webkit-reviews mailing list