[webkit-reviews] review granted: [Bug 30417] Need to properly disable applicationCache at runtime : [Attachment 42499] Revised fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 4 11:22:32 PST 2009


David Levin <levin at chromium.org> has granted Jenn Braithwaite
<jennb at chromium.org>'s request for review:
Bug 30417: Need to properly disable applicationCache at runtime
https://bugs.webkit.org/show_bug.cgi?id=30417

Attachment 42499: Revised fix
https://bugs.webkit.org/attachment.cgi?id=42499&action=review

------- Additional Comments from David Levin <levin at chromium.org>
> Index: WebCore/ChangeLog
> +	   Just adding a bit, so new tests.

I think you have not really changed the visible functionality so no new tests.

> Index: WebCore/bindings/v8/custom/V8CustomBinding.h
>  #if ENABLE(OFFLINE_WEB_APPLICATIONS)
> +	DECLARE_ACCESSOR_RUNTIME_ENABLER(DOMApplicationCache);

Another TAB to remove.

I can fix this on landing.


More information about the webkit-reviews mailing list