[webkit-reviews] review granted: [Bug 31089] Uninitialized member m_createdByParser in WebCore::ProcessingInstruction : [Attachment 42484] Add mising initializer

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 4 10:09:25 PST 2009


Eric Seidel <eric at webkit.org> has granted Dan Kegel <dank at kegel.com>'s request
for review:
Bug 31089: Uninitialized member m_createdByParser in
WebCore::ProcessingInstruction
https://bugs.webkit.org/show_bug.cgi?id=31089

Attachment 42484: Add mising initializer
https://bugs.webkit.org/attachment.cgi?id=42484&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
You can leave the "Reviewed by NOBODY (OOPS!)." line alone and our scripts will
fill it in automatically with Alexey's full name when landing.	It would be
better for you to paste an un-altered NOBODY line, or to correct that to say
"Alexey Proskuryakov." (with a period), before we land this.

LGTM, and someone could land this manually with that fix, but we should get the
ChangeLog completely right (either left as NOBODY (OOPS!) or changed to
Alexey's full name with a period) if we want the commit-queue to land this.

Thanks for the patch!


More information about the webkit-reviews mailing list