[webkit-reviews] review denied: [Bug 31121] WebInspector: Prevent crash when InspectorTimelineAgent is enabled/disabled: follow on to bug 31080 : [Attachment 42488] WebInspector: Handle turning timeline profiling on/off in the middle of event dispatch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 4 09:36:36 PST 2009


Timothy Hatcher <timothy at hatcher.name> has denied  review:
Bug 31121: WebInspector: Prevent crash when InspectorTimelineAgent is
enabled/disabled: follow on to bug 31080
https://bugs.webkit.org/show_bug.cgi?id=31121

Attachment 42488: WebInspector: Handle turning timeline profiling on/off in the
middle of event dispatch
https://bugs.webkit.org/attachment.cgi?id=42488&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>

>  #if ENABLE(INSPECTOR)
> +	 timelineAgent =
InspectorTimelineAgent::retrieve(scriptExecutionContext());
>	   bool callTimelineAgentOnLoad = timelineAgent &&
hasEventListeners(eventNames().loadEvent);

Bad indentation here.

Also remore the tabs from the ChangeLog.


More information about the webkit-reviews mailing list