[webkit-reviews] review requested: [Bug 20780] when choosing an auto-completed value in a text input field the javascript 'change' event is not fired. : [Attachment 42464] Patch with manual test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 4 01:24:51 PST 2009


Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 20780: when choosing an auto-completed value in a text input field the
javascript 'change' event is not fired.
https://bugs.webkit.org/show_bug.cgi?id=20780

Attachment 42464: Patch with manual test
https://bugs.webkit.org/attachment.cgi?id=42464&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
Renamed RenderTextControl::m_edited to m_wasEditedSinceLastChangeEvent and
RenderTextControl::m_userEdited to m_wasLastEditedByAUser, to reflect that
whether the text control was changed since the last change event fired and
whether a human performed the last edit (as opposed to being done
programmatically), respectively. Also, renamed their corresponding getters and
setters.

Let me know if these names are not sufficient.


More information about the webkit-reviews mailing list