[webkit-reviews] review denied: [Bug 31067] Chromium crashes when a plugin invokes the document.open function via NPAPI : [Attachment 42435] Initial patch with layout tests.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 3 21:52:34 PST 2009


Adam Barth <abarth at webkit.org> has denied Ananta Iyengar
<ananta at chromium.org>'s request for review:
Bug 31067: Chromium crashes when a plugin invokes the document.open function
via NPAPI
https://bugs.webkit.org/show_bug.cgi?id=31067

Attachment 42435: Initial patch with layout tests.
https://bugs.webkit.org/attachment.cgi?id=42435&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This looks great.  A couple minor issues:

 123	 if (frame)
 124	     htmlDocument->write(writeHelperGetString(args),
frame->document());

We can call htmlDocument->write even when |frame| is null.  We can just pass a
null second argument.

In your LayoutTest/ChangeLog, you have several copies of the change
description.


More information about the webkit-reviews mailing list