[webkit-reviews] review denied: [Bug 31080] WebInspector: Handle turning TimelineAgent on/off in the middle of an event dispatch : [Attachment 42423] WebInspector: bug 31080, Handle turning profiling on/off in the middle of event dispatch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 3 15:15:55 PST 2009


Timothy Hatcher <timothy at hatcher.name> has denied  review:
Bug 31080: WebInspector: Handle turning TimelineAgent on/off in the middle of
an event dispatch
https://bugs.webkit.org/show_bug.cgi?id=31080

Attachment 42423: WebInspector: bug 31080, Handle turning profiling on/off in
the middle of event dispatch
https://bugs.webkit.org/attachment.cgi?id=42423&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>

> -	   if (timelineAgent)
> -	       timelineAgent->didFireTimer();
> +    if (InspectorTimelineAgent* timelineAgent =
InspectorTimelineAgent::retrieve(context))
> +	   timelineAgent->didFireTimer();
>  #endif
>	   return;

Bad indent.


More information about the webkit-reviews mailing list