[webkit-reviews] review requested: [Bug 31035] [GTK] some accessibility tests hitting assertion in debug builds : [Attachment 42426] Replace assertions with sanity checks - take 2

[bugzilla-daemon at webkit.org]

Joanmarie Diggs <joanmarie.diggs at gmail.com> has asked  for review:
Bug 31035: [GTK] some accessibility tests hitting assertion in debug builds
https://bugs.webkit.org/show_bug.cgi?id=31035

Attachment 42426: Replace assertions with sanity checks - take 2
https://bugs.webkit.org/attachment.cgi?id=42426&action=review

------- Additional Comments from Joanmarie Diggs <joanmarie.diggs at gmail.com>
(In reply to comment #7)
> (From update of attachment 42359 [details])
> > +	 AccessibilityObject::AccessibilityChildrenVector children =
coreObject->children();
> > +	 if (index < 0 || index >= children.size())
> > +	     return 0;
> >  
> >	 AccessibilityObject* coreChild =
coreObject->children().at(index).get();
> 
> It would be nice if we can just reuse children here instead of calling to
> coreObject again.

Yup. Done. Thanks for the review!