[webkit-reviews] review denied: [Bug 31082] Web Inspector - Adds markTimeline() API to the console for annotating the timeline tree : [Attachment 42415] Patch to add console.markTimeline()

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied jaimeyap at google.com's request
for review:
Bug 31082: Web Inspector - Adds markTimeline() API to the console for
annotating the timeline tree
https://bugs.webkit.org/show_bug.cgi?id=31082

Attachment 42415: Patch to add console.markTimeline()
https://bugs.webkit.org/attachment.cgi?id=42415&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
> +{
> +    if (timelineAgent())
> +	 timelineAgent()->didMarkTimeline(message);

wrong indent

> +	   MarkTimelineRecordType = 11,

will be a conflict with resources events, who gets r+ first? :)

> +    page->inspectorController()->markTimeline(message);

we could pass the stack and try doing .log-alike the formatting, but that is
too hard.

r- for indent. otherwise good.