[webkit-reviews] review denied: [Bug 30913] Web Inspector: hover over JS "things" in source and see their values : [Attachment 42390] Initial implementation
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Nov 3 09:55:00 PST 2009
Timothy Hatcher <timothy at hatcher.name> has denied Keishi Hattori
<casey.hattori at gmail.com>'s request for review:
Bug 30913: Web Inspector: hover over JS "things" in source and see their values
https://bugs.webkit.org/show_bug.cgi?id=30913
Attachment 42390: Initial implementation
https://bugs.webkit.org/attachment.cgi?id=42390&action=review
------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
> + identElement.addEventListener("mouseover", function(event) {
Can you split out the inline functions and give them named and put them
somewhere and reference them by name? They are too long to be good inline.
> + }
> + var expression = parts.join(".");
Put a new line between these lines.
> +
WebInspector.panels.scripts.evaluateInSelectedCallFrame(expression, false,
"console", function(result, exception) {
Again break out the inline function.
> + function onmouseout(event) {
Brace on the next line.
More information about the webkit-reviews
mailing list