[webkit-reviews] review granted: [Bug 31064] Web Inspector: Implement timeline summary panel. : [Attachment 42389] [PATCH] Proposed patch.

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 31064: Web Inspector: Implement timeline summary panel.
https://bugs.webkit.org/show_bug.cgi?id=31064

Attachment 42389: [PATCH] Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=42389&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>

> +	    // Create sparse arrays 101 cell each to fill with chunks for a
given category.

Should be: "Create sparse arrays with 101 cells each…"

> +	    // Convert sparse arrays to continues segments, render graphs for
each.

Should be "Convert sparse arrays to continuous segments…"

> +	   while (this._barAreaElement.firstChild)
> +	      
this._barAreaElement.removeChild(this._barAreaElement.firstChild);

Just do this._barAreaElement.removeChildren() (from utilities.js)