[webkit-reviews] review requested: [Bug 31049] Watch expression editor should stay open after Add button was clicked : [Attachment 42387] proposed patch 2009/11/03 - a

[bugzilla-daemon at webkit.org]

Patrick Mueller <pmuellr at yahoo.com> has asked  for review:
Bug 31049: Watch expression editor should stay open after Add button was
clicked
https://bugs.webkit.org/show_bug.cgi?id=31049

Attachment 42387: proposed patch 2009/11/03 - a
https://bugs.webkit.org/attachment.cgi?id=42387&action=review

------- Additional Comments from Patrick Mueller <pmuellr at yahoo.com>
Moved the code to put the entry into "edit" mode into the path where the entry
is added to the tree.  With the new async eval(), the old code path would never
work, because the entry wasn't added by the time the code was run.  

Because the new check for "edit" mode is now in a code path that runs a lot
more often, also added a flag - _newExpressionAdded - to indicate when the
check should be made, since it requires a linear search through the watch
expressions, and could in theory be expensive.