[webkit-reviews] review granted: [Bug 31056] Web Inspector: Implement Timeline Window, wire it to the bottom timeline. : [Attachment 42373] [PATCH] Timeline window.

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 31056: Web Inspector: Implement Timeline Window, wire it to the bottom
timeline.
https://bugs.webkit.org/show_bug.cgi?id=31056

Attachment 42373: [PATCH] Timeline window.
https://bugs.webkit.org/attachment.cgi?id=42373&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
> +    addExtraDivider: function(divider)
> +    {
> +	   this._eventDividersElement.appendChild(divider);
> +    },

This sound be _extraDividersElement if the function is addExtraDivider.


> +	   return Number.secondsToString(value + this.minimumBoundary -
this._minimumBoundary, WebInspector.UIString.bind(WebInspector));

The "this.minimumBoundary - this._minimumBoundary" line needs clarified. We
should renamed _minimumBoundary to mean "minimum boundry ignoring window",
maybe add a getter for that too.