[webkit-reviews] review denied: [Bug 31052] Web Inspector: Prepare for heap profiles upstreaming : [Attachment 42367] proposed change

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 3 06:34:21 PST 2009


Pavel Feldman <pfeldman at chromium.org> has denied Mikhail Naganov
<mnaganov at chromium.org>'s request for review:
Bug 31052: Web Inspector: Prepare for heap profiles upstreaming
https://bugs.webkit.org/show_bug.cgi?id=31052

Attachment 42367: proposed change
https://bugs.webkit.org/attachment.cgi?id=42367&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
> -   
this.panels.profiles.addProfileHeader(WebInspector.CPUProfileType.TypeId, new
WebInspector.CPUProfile(profile));
> +    this.panels.profiles.addProfileHeader(profile.typeId, profile);

If every profile has typeId from now on, should we pass single argument here?


More information about the webkit-reviews mailing list