[webkit-reviews] review denied: [Bug 31035] [GTK] some accessibility tests hitting assertion in debug builds : [Attachment 42359] Replace assertions with sanity checks

[bugzilla-daemon at webkit.org]

Jan Alonzo <jmalonzo at gmail.com> has denied Joanmarie Diggs
<joanmarie.diggs at gmail.com>'s request for review:
Bug 31035: [GTK] some accessibility tests hitting assertion in debug builds
https://bugs.webkit.org/show_bug.cgi?id=31035

Attachment 42359: Replace assertions with sanity checks
https://bugs.webkit.org/attachment.cgi?id=42359&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
> +    AccessibilityObject::AccessibilityChildrenVector children =
coreObject->children();
> +    if (index < 0 || index >= children.size())
> +	   return 0;
>  
>      AccessibilityObject* coreChild = coreObject->children().at(index).get();


It would be nice if we can just reuse children here instead of calling to
coreObject again.

r- because it needs one more round.