[webkit-reviews] review requested: [Bug 30979] [Qt] REGRESSION: Allow applications to use their own QWidget bypassing QWebView. : [Attachment 42333] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Nov 2 12:06:11 PST 2009
Yael <yael.aharon at nokia.com> has asked for review:
Bug 30979: [Qt] REGRESSION: Allow applications to use their own QWidget
bypassing QWebView.
https://bugs.webkit.org/show_bug.cgi?id=30979
Attachment 42333: Patch
https://bugs.webkit.org/attachment.cgi?id=42333&action=review
------- Additional Comments from Yael <yael.aharon at nokia.com>
(In reply to comment #4)
> It appears the fix would be to rip out the QWebPageClient implementation from
> QWebViewPrivate, turn into into a private standalone class (say
> QWebPageWidgetClient) and use it independently from QWebView. I guess
QWebPage
> should own/allocate the instance when QWebPage::setView() is called.
This patch does what you suggested.
More information about the webkit-reviews
mailing list