[webkit-reviews] review denied: [Bug 27492] Web Sockets Test Infrastructure Part 3/3: Example test : [Attachment 41998] Add a simple web socket test.

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Yuzo Fujishima <yuzo at google.com>'s
request for review:
Bug 27492: Web Sockets Test Infrastructure Part 3/3: Example test
https://bugs.webkit.org/show_bug.cgi?id=27492

Attachment 41998: Add a simple web socket test.
https://bugs.webkit.org/attachment.cgi?id=41998&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Just some minor issues to address and this should be fine to go in.

> diff --git a/LayoutTests/websocket/tests/resources/simple.js
b/LayoutTests/websocket/tests/resources/simple.js

I think this is in the wrong place after Hamaji's changes.


> diff --git a/LayoutTests/websocket/tests/simple_wsh.py
b/LayoutTests/websocket/tests/simple_wsh.py
> new file mode 100755
> index 0000000..5dc71bd
> --- /dev/null
> +++ b/LayoutTests/websocket/tests/simple_wsh.py
> @@ -0,0 +1,42 @@
> +# Copyright 2009, Google Inc.
> +# All rights reserved.

Please use the standard copyright style for WebKit.

Ideally the copyright would be of this format:
   Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
   Copyright (C) 2009 Somebody <email>


> +def web_socket_do_extra_handshake(request):
> +    pass  # Always accept.

In keeping with out Webkit code, please use one space before end of line
comments.


> +# vi:sts=4 sw=4 et

No other WebKit sources have this vi formating info. Please remove it.