[webkit-reviews] review denied: [Bug 27491] Web Sockets Test Infrastructure Part 2/3: Patch to run-webkit-tests : [Attachment 41845] Start/Stop Web Socket and Web Socket Secure servers for layout tests.

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Yuzo Fujishima <yuzo at google.com>'s
request for review:
Bug 27491: Web Sockets Test Infrastructure Part 2/3: Patch to run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=27491

Attachment 41845: Start/Stop Web Socket and Web Socket Secure servers for
layout tests.
https://bugs.webkit.org/attachment.cgi?id=41845&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Just one issue.

> diff --git a/WebKitTools/Scripts/run-webkit-tests
b/WebKitTools/Scripts/run-webkit-tests
> @@ -604,6 +603,32 @@ for my $test (@tests) {
>	       }
>	       print OUT "$testPath$suffixExpectedHash\n";
>	   }
> +    } elsif ($test =~ /^websocket\//) {
> +	   openWebSocketServerIfNeeded();

It seems like this should be in the "else" below because some of these test may
run without needing the web socket server started.

> +	   if ($test =~ /^websocket\/tests\/local\//) {
> +	       my $testPath = "$testDirectory/$test";
> +	       if (isCygwin()) {
> +		   $testPath = toWindowsPath($testPath);
> +	       } else {
> +		   $testPath = canonpath($testPath);
> +	       }
> +	       print OUT "$testPath\n";
> +	   } else {
> +	       my $path = canonpath($test);
> +	       if ($test =~ /^websocket\/tests\/ssl\//) {
> +		   print OUT "https://127.0.0.1:$webSocketSecurePort/$path\n";
> +	       } else {
> +		   print OUT "http://127.0.0.1:$webSocketPort/$path\n";
> +	       }
> +	   }