[webkit-reviews] review denied: [Bug 30997] [Gtk] Implement AtkDocument's attribute support : [Attachment 42301] Layout Test - Take 1

[bugzilla-daemon at webkit.org]

Jan Alonzo <jmalonzo at gmail.com> has denied Joanmarie Diggs
<joanmarie.diggs at gmail.com>'s request for review:
Bug 30997: [Gtk] Implement AtkDocument's attribute support
https://bugs.webkit.org/show_bug.cgi?id=30997

Attachment 42301: Layout Test - Take 1
https://bugs.webkit.org/attachment.cgi?id=42301&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
Thanks for writing the test.

> diff --git a/LayoutTests/accessibility/document-attributes-expected.txt
b/LayoutTests/accessibility/document-attributes-expected.txt
> new file mode 100644
> index 0000000..863339f
> --- /dev/null
> +++ b/LayoutTests/accessibility/document-attributes-expected.txt
> @@ -0,0 +1 @@
> +Passed

Is the result platform-specific? If so, we should put the -expected.txt into
the platform-specific folders. See "add-platform-exceptions" option of
run-webkit-tests to generate a platform-specific expected result.

> --- a/WebKitTools/DumpRenderTree/mac/AccessibilityUIElementMac.mm
> +++ b/WebKitTools/DumpRenderTree/mac/AccessibilityUIElementMac.mm
> @@ -577,3 +577,13 @@ JSStringRef AccessibilityUIElement::accessibilityValue()
const
>      // FIXME: implement
>      return JSStringCreateWithCharacters(0, 0);
>  }
> +
> +JSStringRef AccessibilityUIElement::documentEncoding()
> +{
> +    return JSStringCreateWithCharacters(0, 0);
> +}
> +
> +JSStringRef AccessibilityUIElement::documentURI()
> +{
> +    return JSStringCreateWithCharacters(0, 0);
> +}
> diff --git a/WebKitTools/DumpRenderTree/win/AccessibilityUIElementWin.cpp
b/WebKitTools/DumpRenderTree/win/AccessibilityUIElementWin.cpp
> index 2a8eaf6..89e9a5c 100644
> --- a/WebKitTools/DumpRenderTree/win/AccessibilityUIElementWin.cpp
> +++ b/WebKitTools/DumpRenderTree/win/AccessibilityUIElementWin.cpp
> @@ -392,3 +392,14 @@ JSStringRef AccessibilityUIElement::accessibilityValue()
const
>  
>      return JSStringCreateWithCharacters(value.data(), value.length());
>  }
> +
> +
> +JSStringRef AccessibilityUIElement::documentEncoding()
> +{
> +    return JSStringCreateWithCharacters(0, 0);
> +}
> +
> +JSStringRef AccessibilityUIElement::documentURI()
> +{
> +    return JSStringCreateWithCharacters(0, 0);
> +}

Since Mac & Win are stubbed, I think this test will need to be added to Mac &
Win's Skipped list (see LayoutTests/platform/{mac,win}/Skipped). Ditto with Qt.


You also missed the impl for Qt :).

r- for now until the above points are addressed.