[webkit-reviews] review denied: [Bug 30907] Web Inspector: Rewrite CSSSourceSyntaxHighlighter so it shares more code : [Attachment 42293] proposed patch 3

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has denied Keishi Hattori
<casey.hattori at gmail.com>'s request for review:
Bug 30907: Web Inspector: Rewrite CSSSourceSyntaxHighlighter so it shares more
code
https://bugs.webkit.org/show_bug.cgi?id=30907

Attachment 42293: proposed patch 3
https://bugs.webkit.org/attachment.cgi?id=42293&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
propertyKeywords, valueKeywords, mediaTypes and keywords should be objects with
properties not arrays. That way it is fast to look up.

So:

const mediaTypes = {"all": true, "aural": true, "braille": true, "embossed":
true, "handheld": true, "print": true, "projection": true, "screen": true,
"tty": true, "tv": true};

And test like:

token in mediaTypes