[webkit-reviews] review granted: [Bug 29972] Implement URL decomposition IDL attributes for HTMLAnchorElement : [Attachment 42285] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Yael <yael.aharon at nokia.com>'s
request for review:
Bug 29972: Implement URL decomposition IDL attributes for HTMLAnchorElement
https://bugs.webkit.org/show_bug.cgi?id=29972

Attachment 42285: Patch
https://bugs.webkit.org/attachment.cgi?id=42285&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
>  bool protocolIs(const String& url, const char* protocol);
>  bool protocolIsJavaScript(const String& url);
> +bool protocolIsValid(const String& protocol);

Sorry I didn’t realize this in earlier patch rounds. The other functions here
work on URLs and check various aspects of the protocol. This new one works on a
protocol.

I think it should be named isValidProtocol instead of protocolIsValid, to make
this slightly clearer. This name change can happen in a separate patch.

I didn’t look too closely at anything else in this patch -- a cursory look
seems to indicate it’s right, so r=me