[webkit-reviews] review granted: [Bug 30986] Fix layering violations in GraphicsContext3D : [Attachment 42267] Remove canvas and image element uses from CanvasRenderingContext3D
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Nov 1 13:18:16 PST 2009
Darin Adler <darin at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 30986: Fix layering violations in GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=30986
Attachment 42267: Remove canvas and image element uses from
CanvasRenderingContext3D
https://bugs.webkit.org/attachment.cgi?id=42267&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
> + CachedImage* cachedImage = image->cachedImage();
> + if (!cachedImage)
> + return;
> + m_context->texSubImage2D(target, level, xoffset, yoffset, width, height,
cachedImage->image(), flipY, premultiplyAlpha);
> cleanupAfterGraphicsCall(false);
All the other cases you put a blank line after the early return.
r=me
More information about the webkit-reviews
mailing list