[webkit-reviews] review cancelled: [Bug 13233] Need to implement an optimizing XPath evaluator : [Attachment 30817] Don't needlessly sort location path results

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 31 22:25:52 PDT 2009


Alexey Proskuryakov <ap at webkit.org> has cancelled 's request for review:
Bug 13233: Need to implement an optimizing XPath evaluator
https://bugs.webkit.org/show_bug.cgi?id=13233

Attachment 30817: Don't needlessly sort location path results
https://bugs.webkit.org/attachment.cgi?id=30817&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
Committed revision 44307, clearing review flag.

> You should instead delete these explicit definitions. The compiler defaults
> would work fine.

Done.

> I don't know why. The logical operations and binary operations both do the
same
> thing with booleans, except for their short-circuiting properties.

It's not so good for BOOLs and Booleans, but OK, changed it when landing this
patch.


More information about the webkit-reviews mailing list