[webkit-reviews] review granted: [Bug 19991] WebKit needs cross-platform filter system : [Attachment 30820] SVG filter system without subRegions

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 31 15:58:25 PDT 2009


Nikolas Zimmermann <zimmermann at kde.org> has granted Dirk Schulze
<krit at webkit.org>'s request for review:
Bug 19991: WebKit needs cross-platform filter system
https://bugs.webkit.org/show_bug.cgi?id=19991

Attachment 30820: SVG filter system without subRegions
https://bugs.webkit.org/attachment.cgi?id=30820&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Looks good, r=me. Please fix style issue "static_cast<..> (" ->
"static_cast<...>(" before landing.
As discussed on IRC, a follow-up patch will also clean up SVGFilterEffect,
which contains unncessary things like "String m_result" etc


More information about the webkit-reviews mailing list