[webkit-reviews] review granted: [Bug 19991] WebKit needs cross-platform filter system : [Attachment 30777] feFloos need input effect

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Dirk Schulze
<krit at webkit.org>'s request for review:
Bug 19991: WebKit needs cross-platform filter system
https://bugs.webkit.org/show_bug.cgi?id=19991

Attachment 30777: feFloos need input effect
https://bugs.webkit.org/attachment.cgi?id=30777&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog (revision 44264)
> +++ WebCore/ChangeLog (working copy)
> @@ -1,3 +1,21 @@
> +2009-05-29  Dirk Schulze  <krit at webkit.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   SVG filter feFlood needs an input effect. This change
> +	   helps creating test cases, once filters are activated.

Hi Dirk, r=me.
Though the ChangeLog is unclear, how about "Adding 'in1' attribute support for
<feFlood>, as specified in SVG 1.1". ?