[webkit-reviews] review granted: [Bug 25973] Avoid calling WTF::CurrentThread() from thread-local destructors in Chromium on OSX : [Attachment 30794] Updated according to Michael's comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 30 14:10:57 PDT 2009


Darin Adler <darin at apple.com> has granted Dmitry Titov <dimich at chromium.org>'s
request for review:
Bug 25973: Avoid calling WTF::CurrentThread() from thread-local destructors in
Chromium on OSX
https://bugs.webkit.org/show_bug.cgi?id=25973

Attachment 30794: Updated according to Michael's comments
https://bugs.webkit.org/attachment.cgi?id=30794&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Seems fine.

I think you want a comment in ~ThreadGlobalData explaining why you can't use
isMainThread() at this point, since people working on platforms other than
Chromium might try to "clean this up" and re-break it if there's no comment.


More information about the webkit-reviews mailing list