[webkit-reviews] review granted: [Bug 25807] #ifdef properly the WebCore/platform/gtk/KeyboardCodes.h : [Attachment 30766] using svn-create-patch

[bugzilla-daemon at webkit.org]

Holger Freyther <zecke at selfish.org> has granted Fridrich Strba
<fridrich.strba at bluewin.ch>'s request for review:
Bug 25807: #ifdef properly the WebCore/platform/gtk/KeyboardCodes.h
https://bugs.webkit.org/show_bug.cgi?id=25807

Attachment 30766: using svn-create-patch
https://bugs.webkit.org/attachment.cgi?id=30766&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>

> +	   The two KeyboardCodes.h files are basically identical and the
> +	   qt one is properly #ifdef-ed for different win32 systems. Share
> +		them between Qt and Gtk implementations

tabs... the pre-commit hook will curse me :)