[webkit-reviews] review denied: [Bug 26034] Loading url with anchor should keep page scrolled to anchor while images load and scripts run : [Attachment 30745] patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Nate Chapin <japhet at google.com>'s
request for review:
Bug 26034: Loading url with anchor should keep page scrolled to anchor while
images load and scripts run
https://bugs.webkit.org/show_bug.cgi?id=26034

Attachment 30745: patch
https://bugs.webkit.org/attachment.cgi?id=30745&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
Yeah this is really close.  The one thing I think you are missing here is that
all scrolls should turn off the lock and not just user scrolls.  For example if
the page focuses a text field after the anchor jump, and we scroll to expose
that text field, you can't then jump back to the anchor.  If a page sets
body.scrollTop back to 0, you can't jump back to the anchor after that, etc. 
Basically you need to turn off the lock if any scrolling happens AT ALL (other
than the gotoAnchor scroll obviously).