[webkit-reviews] review denied: [Bug 25972] Help Disambiguate min/max calls in TimeRanges : [Attachment 30755] Correct build error.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 29 07:53:15 PDT 2009

Darin Adler <darin at apple.com> has denied Brent Fulgham <bfulgham at webkit.org>'s
request for review:
Bug 25972: Help Disambiguate min/max calls in TimeRanges

Attachment 30755: Correct build error.

------- Additional Comments from Darin Adler <darin at apple.com>
This is close to correct, but not quite.

Since this is a header, it's not appropriate to say "using namespace std" here.
We need to remove that. Adding the include of <algorithm> is also good, but it
needs to be sorted in with the rest of the includes, not a separate paragraph.
And we do indeed need to add the "std::" prefixes.

Further, SMILTime.h should not define min and max functions, since the std
versions will work fine on SMILTime objects.

review- because I'd prefer to see a patch that removes the incorrect "using
namespace std".

More information about the webkit-reviews mailing list