[webkit-reviews] review requested: [Bug 25072] CSS21 attribute selectors not dynamic for xml : [Attachment 30768] Updated patch and test case
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 29 01:51:27 PDT 2009
Kai Brüning <kai at granus.net> has asked for review:
Bug 25072: CSS21 attribute selectors not dynamic for xml
https://bugs.webkit.org/show_bug.cgi?id=25072
Attachment 30768: Updated patch and test case
https://bugs.webkit.org/attachment.cgi?id=30768&action=review
------- Additional Comments from Kai Brüning <kai at granus.net>
As suggested, I changed ownerDocument() to document(). This is inline instead
of virtual, so its faster, too. But even ownerDocument() would never be null
here because we are in an Element which cant be the document.
Still: why does the code in StyledElement from which I copied this use
ownerDocument()?
Additionally, I changed the test to display "FAILED" or "PASSED" and added the
pixel result.
More information about the webkit-reviews
mailing list