[webkit-reviews] review requested: [Bug 25902] Need to implement WorkerContext.close() : [Attachment 30752] proposed patch with requested changes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 28 14:51:00 PDT 2009


Andrew Wilson <atwilson at google.com> has asked  for review:
Bug 25902: Need to implement WorkerContext.close()
https://bugs.webkit.org/show_bug.cgi?id=25902

Attachment 30752: proposed patch with requested changes
https://bugs.webkit.org/attachment.cgi?id=30752&action=review

------- Additional Comments from Andrew Wilson <atwilson at google.com>
Updated patch with requested tests. The latest spec for WorkerContext.close()
discards all pending events, so I've updated the code and tests to reflect
this.

Note that there's a minor issue with pending XMLHttpRequest events - those
aren't always delivered via the event queue, so if you call
WorkerContext.close() from an XHR callback you can still get another event
callback invoked before the thread exits. I'll log a separate bug for this.


More information about the webkit-reviews mailing list