[webkit-reviews] review granted: [Bug 26001] Change callers of String::adopt() to String::createUninitialized() : [Attachment 30737] Fix

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Dave Moore <davemoore at google.com>'s
request for review:
Bug 26001: Change callers of String::adopt() to String::createUninitialized()
https://bugs.webkit.org/show_bug.cgi?id=26001

Attachment 30737: Fix
https://bugs.webkit.org/attachment.cgi?id=30737&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	   if (c->nodeType() == Node::TEXT_NODE || c->nodeType() ==
Node::CDATA_SECTION_NODE || c->nodeType() == Node::COMMENT_NODE) {

Since nodeType() is a virtual function, it's too bad we're calling it three
times on each non-textual node.

> +	       int nodeLength = nodeValue.length();

Should be unsigned, not int.

> +	   int dataLength = data.length();

Should be unsigned, not int.

r=me