[webkit-reviews] review granted: [Bug 26041] Allow adding resource source to frame asynchronously : [Attachment 30732] Complete source frame loading in iframe 'load' event listener.

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 26041: Allow adding resource source to frame asynchronously
https://bugs.webkit.org/show_bug.cgi?id=26041

Attachment 30732: Complete source frame loading in iframe 'load' event
listener.
https://bugs.webkit.org/attachment.cgi?id=30732&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
Seems odd addSourceToFrame returns a bool and addResourceSourceToFrame does
not. Can addResourceSourceToFrame still return a bool? If the resource isn't
found retuen false and retuen the result of addSourceToFrame.

+	 delete this._frameNeedsSetup;

You shouldn't need this sine _frameNeedsSetup was deleted in
setupSourceFrameIfNeeded.