[webkit-reviews] review requested: [Bug 26057] StringImpl should share buffers with UString and cross-thread. : [Attachment 30729] Proposed fix.

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has asked  for review:
Bug 26057: StringImpl should share buffers with UString and cross-thread.
https://bugs.webkit.org/show_bug.cgi?id=26057

Attachment 30729: Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=30729&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Some perf test results:

On http://www.hixie.ch/tests/adhoc/perf/dom/artificial/core/001.html
the time went from 78ms to 40ms for append (other times remained constant).

On http://www.hixie.ch/tests/adhoc/perf/dom/artificial/core/002.html,
the time went from 3900ms to 2600ms.

For http://dromaeo.com/?dom, the time for DomModification improved by ~6%. 
Other tests in dom seemed to be faster across several runs but within the
margin of error (except DOM Attributes which was slightly ~1.5% worse).