[webkit-reviews] review granted: [Bug 21794] Middle-click panning should be springloaded while dragging : [Attachment 30713] Comments by John Honeycutt addressed

[bugzilla-daemon at webkit.org]

Jon Honeycutt <jhoneycutt at apple.com> has granted Itai <idanan at chromium.org>'s
request for review:
Bug 21794: Middle-click panning should be springloaded while dragging
https://bugs.webkit.org/show_bug.cgi?id=21794

Attachment 30713: Comments by John Honeycutt addressed
https://bugs.webkit.org/attachment.cgi?id=30713&action=review

------- Additional Comments from Jon Honeycutt <jhoneycutt at apple.com>
> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog (revision 44197)
> +++ WebCore/ChangeLog (working copy)
> @@ -1,3 +1,23 @@
> +2009-05-27  Itai Danan  <idanan at chromium.org>
> +
> +	   Reviewed by jhoneycutt at apple.com.

We usually use the reviewer's name; I'm Jon Honeycutt.

> +
> +	   As per Bug 21794 (https://bugs.webkit.org/show_bug.cgi?id=21794),
> +	added an option for springloaded panscroll instead of sticky
> +	scroll. To understand why this is required see the discussion in
> +	issue 24722 (https://bugs.webkit.org/show_bug.cgi?id=24722).
> +
> +	   * page/EventHandler.cpp:
> +	   (WebCore::EventHandler::handleMousePressEvent): Use autoscroll
behavior flag to determine
> +	if autoscroll needs to be released on this event.
> +	   (WebCore::EventHandler::handleMouseReleaseEvent):  Use autoscroll
behavior flag to determine
> +	if autoscroll needs to be released on this event (reverse logic of for
Press event).

I think you added some tabs here. WebKit uses 4 spaces for indentation.

r=me if you fix the tabs. Thanks for the patch, Itai!