[webkit-reviews] review granted: [Bug 25911] Apply href in base elements to anchors shown on the source viewer : [Attachment 30644] Proposed fix for 25911 (rev2)

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Takeshi Yoshino
<tyoshino at google.com>'s request for review:
Bug 25911: Apply href in base elements to anchors shown on the source viewer
https://bugs.webkit.org/show_bug.cgi?id=25911

Attachment 30644: Proposed fix for 25911 (rev2)
https://bugs.webkit.org/attachment.cgi?id=30644&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +			       if (token->tagName == baseTag &&
equalIgnoringCase(attr->name().localName(), "href")) {

I'm not sure why the code in this class checks attribute names in this
inefficient way. In normal WebCore code we would just compare with hrefAttr
using == instead.

r=me